Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pod tolerations #650

Merged
merged 5 commits into from
Aug 23, 2024
Merged

Add support for pod tolerations #650

merged 5 commits into from
Aug 23, 2024

Conversation

idlewis
Copy link
Collaborator

@idlewis idlewis commented Aug 21, 2024

First part of support for WASdev/websphere-liberty-operator#652

@idlewis idlewis self-assigned this Aug 21, 2024
@idlewis idlewis marked this pull request as draft August 21, 2024 09:32
Copy link
Member

@leochr leochr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@idlewis Looks good. Just one minor suggestion for the description. Thank you

@@ -153,6 +153,10 @@ type RuntimeComponentSpec struct {
// Disable information about services being injected into the application pod's environment variables. Default to false.
// +operator-sdk:csv:customresourcedefinitions:order=27,type=spec,displayName="Disable Service Links",xDescriptors="urn:alm:descriptor:com.tectonic.ui:booleanSwitch"
DisableServiceLinks *bool `json:"disableServiceLinks,omitempty"`

// Tolerations to be added to application pods.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Tolerations to be added to the application pods. Tolerations allow the scheduler to schedule pods on nodes with matching taints.

@idlewis idlewis marked this pull request as ready for review August 23, 2024 13:50
@idlewis
Copy link
Collaborator Author

idlewis commented Aug 23, 2024

Copy link
Member

@leochr leochr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@idlewis Thank you. Looks good.

@leochr leochr merged commit f0681bd into main Aug 23, 2024
@leochr leochr deleted the tolerate branch August 23, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants