-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for pod tolerations #650
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@idlewis Looks good. Just one minor suggestion for the description. Thank you
api/v1/runtimecomponent_types.go
Outdated
@@ -153,6 +153,10 @@ type RuntimeComponentSpec struct { | |||
// Disable information about services being injected into the application pod's environment variables. Default to false. | |||
// +operator-sdk:csv:customresourcedefinitions:order=27,type=spec,displayName="Disable Service Links",xDescriptors="urn:alm:descriptor:com.tectonic.ui:booleanSwitch" | |||
DisableServiceLinks *bool `json:"disableServiceLinks,omitempty"` | |||
|
|||
// Tolerations to be added to application pods. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Tolerations to be added to the application pods. Tolerations allow the scheduler to schedule pods on nodes with matching taints.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@idlewis Thank you. Looks good.
First part of support for WASdev/websphere-liberty-operator#652