Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to allow multiple /'s in application image #333

Merged
merged 1 commit into from
Mar 7, 2022
Merged

Fix to allow multiple /'s in application image #333

merged 1 commit into from
Mar 7, 2022

Conversation

yongja79
Copy link
Collaborator

@yongja79 yongja79 commented Feb 2, 2022

Signed-off-by: Jason Yong [email protected]

What this PR does / why we need it?:

  • Allows an application image name to have 3 "/"

@yongja79
Copy link
Collaborator Author

yongja79 commented Feb 2, 2022

Fixes #325

@yongja79 yongja79 requested a review from leochr February 2, 2022 15:05
Copy link
Member

@leochr leochr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yongja79 Looks good. Thank you!

@leochr leochr merged commit 742b91a into main Mar 7, 2022
@leochr
Copy link
Member

leochr commented Mar 7, 2022

@halim-lee I've merged this fix into main. Please pull into 0.8.x and also include with OLO. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants