Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix resolving JSON converters with colliding type names in different assemblies #91

Closed
wants to merge 10 commits into from
Closed

Fix resolving JSON converters with colliding type names in different assemblies #91

wants to merge 10 commits into from

Conversation

applejag
Copy link
Owner

Based on @Erifirin's work in #90

  • Changed TypeCache to lookup assemblies in deterministic order
  • Added field converterAssembly to ConverterConfig, so it keeps track of which assembly it belongs to.
  • Changed TypeCache to lookup type in specific assembly, if any is given, but fallback to still looking up in any assembly.

@applejag
Copy link
Owner Author

applejag commented Mar 1, 2024

Closed as this PR is a replica of #90

@applejag applejag closed this Mar 1, 2024
@applejag applejag deleted the feature/converters-resolver branch March 1, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@applejag @Erifirin