script_stop = true - does not stop script after first failure
#233
Comments
|
I will take it. |
appleboy
added
bug
|
@jpdoria Please post your console log. The following is my testing log:
|
|
@appleboy here's the post log:
In your test result above, were you also using |
|
with:
host: ${{ secrets.HOST }}
username: ${{ secrets.USERNAME }}
key: ${{ secrets.KEY }}
port: ${{ secrets.PORT }}
script_stop: true
script: |
mkdir abc/def
ls -al |
|
Your console can't get the log message from |
|
@appleboy, can you also try to use |
|
@jpdoria let me try it. |
|
You got the same problem as above? |
|
@appleboy Yes, that's right. My pipeline took longer so I had to cancel it. In my screenshot above, I left it running for an hour just to see what would happen next but it got stuck. |
|
@jpdoria I can reproduce the problem. I will take it. |
- Add `trimValues` function for cleaning up slice values - Remove unused `wg.Done()` call - Modify `Exec` function to launch goroutines for each host in `Config.Host` - Add test for `ScriptStop` with multiple hosts and sync mode refer to: appleboy/ssh-action#233
|
@jpdoria Please help to try the following version. uses: appleboy/ssh-action@5c089138a7db482bed7054e891898491832c129a |
|
Thanks for the quick fix! |
|
@jpdoria I will bump new version. |
- Update Dockerfile to use a newer version of `drone-ssh` - Modify `ci.yml` to use `continue-on-error` instead of commenting out code fix #233
|
Bump new version v0.1.9 |
|
Sweet! Thanks so much, @appleboy! Really appreciate it! 🙌🏻 |
Hi,
We have a step in our deployment pipeline that needs to be stopped right away on failure. I saw there's a
script_stopoption so I'm following the Stop script after first failure example and I applied it on my test pipeline but it doesn't seem to work - the step still runs after failing and pipeline has been running for an hour now. Could you please help me resolve this? I'm using thisappleboy/[email protected]. Thanks so much!The text was updated successfully, but these errors were encountered: