Fix data race of Scp #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
==================
WARNING: DATA RACE
Write at 0x00c000397240 by goroutine 83:
golang.org/x/crypto/ssh.(*Session).start()
/go/pkg/mod/golang.org/x/[email protected]/ssh/session.go:373 +0x42
golang.org/x/crypto/ssh.(*Session).Start()
/go/pkg/mod/golang.org/x/[email protected]/ssh/session.go:293 +0x28f
golang.org/x/crypto/ssh.(*Session).Run()
/go/pkg/mod/golang.org/x/[email protected]/ssh/session.go:310 +0x50
github.com/appleboy/easyssh-proxy.(*MakeConfig).Scp()
/go/pkg/mod/github.com/appleboy/[email protected]/easyssh.go:356 +0x2e0
....
Previous read at 0x00c000397240 by goroutine 72:
golang.org/x/crypto/ssh.(*Session).StdinPipe()
/go/pkg/mod/golang.org/x/[email protected]/ssh/session.go:545 +0x3d7
github.com/appleboy/easyssh-proxy.(*MakeConfig).Scp.func1()
/go/pkg/mod/github.com/appleboy/[email protected]/easyssh.go:339 +0x7c
|
@appleboy PTAL |
appleboy
approved these changes
Apr 28, 2020
|
bump to v1.3.2 and thanks @july2993 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix DATA RACE
We must call
session.StdinPipebeforesession.Runorsession.StdinPipewill return error if it's started.The origin implementation will just silently quit,
Scp()returningnil, but the file IS NOT copy to remote actually.This PR also check all write to the write and returning the error if we failed to do this.