Bug: Remote URL's Formatting Error

[Blackglade]

Description

I had several builds fail this morning as they tried to push GitHub code to a repo via a drone pipeline. The error occurred in the final step of my pipeline:

  - name: Publish website
    image: appleboy/drone-git-push
    settings:
      remote_name: test_repo
      remote: git@custom_url.com:test/test.git
      branch: gh-pages
      path: /drone/src/website
      key: GIT_PUSH_SSH_KEY
      force: true
    environment:
      GIT_PUSH_SSH_KEY:
        from_secret: GIT_PUSH_SSH_KEY

The error was as follows:

time="2020-03-09T18:33:42Z" level=fatal msg="parse \"git@custom_url.com:test/test.git\": first path segment in URL cannot contain colon"

This is likely occurring because a regression of a previous issue with net/url in 1.14. See this issue: golang/go#29261

Changing the image from appleboy/drone-git-push to appleboy/drone-git-push:0.2.0-linux-alpine to migrate to the last working version resolved the issue.

[appleboy]

I will take it.

[Blackglade]

Awesome! Thanks again! Any idea of an eta till a fix is released?

[decentral1se]

Yeah, running into this... using "[email protected]:repo.git"

[decentral1se]

Work-around is: image: appleboy/drone-git-push:0.2.0-linux-amd64

[emadzz]

The workaround suggested by decentral1se works for me, but are there any plans to fix this in a "latest" version/tag?

[satwell]

Pretty sure this is unrelated to the linked golang bug. That bug is specifically about leading space in front of URLs passed to url.Parse. I'm pretty sure this is a bug related to repo.WriteToken introduced in ca3840a.

repo.WriteToken calls url.Parse, and url.Parse will (correctly) fail because a string like [email protected]:foo/bar is not a valid absolute or relative URL.

So a workaround would be to specify remote in SSH URL format: ssh://[email protected]/user/repo.git. Note that there's a slash between the hostname and the username, not a colon.

It looks like people will only run into this issue if Drone uses authentication for the clone step, e.g., you're running on a private repo or you set DRONE_GIT_ALWAYS_AUTH=true in your Drone server config. In this case, Drone writes credentials into DRONE_NETRC_*, which activates drone-git-push's repo.WriteToken.

[appleboy]

Thanks for @satwell solution

replace

[email protected]:fh-trier/latex-templates.git

with

ssh://[email protected]/fh-trier/latex-templates.git