Some swift-format lint fixes #1721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves the swift-format lint warning _ReplaceForEachWithForLoop_. There isn't a rewrite rule for this so things have to be manually fixed.
Resolves the swift-format lint warnings for OmitExplicitReturns. These cases likely are things that swift-format fails to rewrite for some reason because it can handle other cases just fine.
|
Opened swiftlang/swift-format#812 for the OmitExplicitReturns things that weren't autofixed. |
allevato
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like swift-format failed to fix some
returncases, but also fix some things that were lint only without formatting support.