Add back CustomDebugStringConvertible conformance #1625
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of a wider effort to make breaking changes introduced in
main
non-breaking.#1246 removed the inheritance of
CustomDebugStringConvertible
fromAnyExtensionField
, and instead moved conformance on to the concrete types (OptionalExtensionField
,RepeatedExtensionField
, etc), but wrapping these extensions in#if DEBUG
statements to avoid unnecessary large binary sizes in release mode.This was a breaking change, so we need to find a compromise to make this non-breaking but get some of the release mode binary size improvements.
This PR moves the implementation of the conformance of several types to the
CustomDebugStringConvertible
protocol inside#if DEBUG
clauses, instead of the whole conformance declaration. We won't get the same size savings since the conformances will still be captured by the runtime, but we won't get any breaking changes.