Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the Extension related types Sendable. #1444

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Make the Extension related types Sendable. #1444

merged 1 commit into from
Sep 25, 2023

Conversation

thomasvl
Copy link
Collaborator

No description provided.

@thomasvl
Copy link
Collaborator Author

@FranzBusch @allevato @tbkka @Lukasa do you all see any way to get this to work for Swift 5.6 since Data wasn't Sendable? I'm coming up short on how do this. The only other idea I have to to add the Sendable conformance only for Swift ≥5.7 and dodge the whole issue.

@FranzBusch
Copy link
Member

For 5.6 you can conditionally mark it as @preconcurrency. You just gotta figure out the right dance of #if swift and #if canImport(Darwin).

@thomasvl thomasvl marked this pull request as ready for review September 22, 2023 18:55
@thomasvl
Copy link
Collaborator Author

Now that the min is 5.7, this should be good to go.

@thomasvl thomasvl merged commit bf5e151 into apple:main Sep 25, 2023
9 checks passed
@thomasvl thomasvl deleted the extension_sendable branch September 25, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FranzBusch FranzBusch FranzBusch approved these changes

@allevato allevato allevato approved these changes

@tbkka tbkka Awaiting requested review from tbkka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasvl @FranzBusch @allevato