Update supported Swift/Xcode Versions. #1438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allevato
reviewed
Aug 11, 2023
thomasvl
force-pushed
the
required_versions
branch
from
4536908
to
fe17cf2
Compare
allevato
approved these changes
Aug 11, 2023
FranzBusch
reviewed
Aug 14, 2023
thomasvl
force-pushed
the
required_versions
branch
from
fe17cf2
to
82ee31c
Compare
Update the documentation to reflect that we will try to support the older of the Swift NIO supported version and the minimum Xcode version supported for the Apple AppStore. As of today, that means: - Swift NIO: Swift 5.6 - https://github.com/apple/swift-nio#swiftnio-2 - AppStore: Xcode 14.1 - https://developer.apple.com/news/?id=jd9wcyov#:~:text=Starting%20April%2025%2C%202023%2C%20iOS,or%20later. Xcode 14.1 included Swift 5.7. So we'll support Swift 5.6+, but the Apple deployment minimums are moved up to the values from Xcode 14.1. In addition to the documentation updates, this commit also: - Updates the main Package.swift and SwiftProtobuf.podspec for the new deployment minimums. - Updates the CI setup to the minimum Swift version. NOTE: There are no code changes in this commit, once this CL is landed, the code changes will be done in follow ups since there are generation changes.
thomasvl
force-pushed
the
required_versions
branch
from
82ee31c
to
3ca7144
Compare
FranzBusch
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the documentation to reflect that we will try to support the older of the Swift NIO supported version and the minimum Xcode version supported for the Apple AppStore.
As of today, that means:
Xcode 14.1 included Swift 5.7. So we'll support Swift 5.6+, but the Apple deployment minimums are moved up to the values from Xcode 14.1.
In addition to the documentation updates, this commit also:
NOTE: There are no code changes in this commit, once this CL is landed, the code changes will be done in follow ups since there are generation changes.