Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce deployment targets by 3 versions #18

Merged
merged 4 commits into from
Jun 13, 2023

Conversation

andrewse02
Copy link
Contributor

Motivation

Reduce deployment target by 3 versions to gain more adoption.

Modifications

  • Reduced deployment targets by 3 versions
  • Modified Converter#renderedRequestPath to support iOS 13

Result

Deployment target will be reduced by 3 versions.

Resolves

Related PRs

Package.swift Outdated Show resolved Hide resolved
@andrewse02 andrewse02 requested a review from czechboy0 June 13, 2023 05:54
@andrewse02 andrewse02 requested a review from czechboy0 June 13, 2023 07:45
@czechboy0
Copy link
Contributor

@swift-server-bot add to allowlist

Copy link
Contributor

@czechboy0 czechboy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

Copy link
Collaborator

@simonjbeaumont simonjbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andrewse02 for working on this.

@simonjbeaumont simonjbeaumont merged commit 02ae849 into apple:main Jun 13, 2023
@simonjbeaumont simonjbeaumont added the 🔨 semver/patch No public API change. label Jun 13, 2023
@andrewse02
Copy link
Contributor Author

You're welcome! This package is awesome, I definitely plan to continue to contribute in my free time!

simonjbeaumont pushed a commit to apple/swift-openapi-urlsession that referenced this pull request Jun 13, 2023
…#7)

### Motivation

Reduce deployment target by 3 versions to gain more adoption.

### Modifications

- Added new deployment targets
- Refactor `invokeSession` method to support iOS 13+
- Update `swift-openapi-runtime` version once changes are done
[there](apple/swift-openapi-runtime#18).

### Result

Deployment target will be reduced by 3 versions.
simonjbeaumont pushed a commit to apple/swift-openapi-generator that referenced this pull request Jun 13, 2023
### Motivation

Reduce deployment target by 3 versions to gain more adoption.

### Modifications

- Reduced deployment targets by 3 versions
- Modified `client.Package.x` and `server.Package.x` files to reflect
new deployment targets
- Modified documentation to reflect new deployment targets

### Result

Deployment target will be reduced by 3 versions and documentation will
reflect such changes.

### Resolves

- Resolves #62

### Related PRs

- Paired with apple/swift-openapi-runtime#18

---------

Co-authored-by: andrewelliott <>
@andrewse02 andrewse02 deleted the ae/reduce-deployment-targets branch June 14, 2023 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support platform versions back to macOS 10.15, iOS 13.0, tvOS 13.0, and watchOS 6.0
3 participants