Conform RuntimeError to HTTPResponseConvertible #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjbeaumont
changed the title
gayathrisairam
force-pushed
the
runtime_error_codes
branch
from
29f3d65 to
52618bb
Compare
gayathrisairam
force-pushed
the
runtime_error_codes
branch
from
d8073b4 to
79bd32a
Compare
simonjbeaumont
approved these changes
Dec 20, 2024
simonjbeaumont
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
apple/swift-openapi-generator#609 (comment)
Modifications
Confirm
RuntimeErrortoHTTPResponseConvertibleand provide granular status codes.Result
Response codes for bad user input will be 4xx (instead of 500)
Test Plan
Unit tests.