Adopt SE-409 #134
Closed
Adopt SE-409 #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranzBusch
reviewed
Dec 17, 2024
| @@ -12,7 +12,7 @@ | |||
| // | |||
| //===----------------------------------------------------------------------===// | |||
| import Foundation | |||
There was a problem hiding this comment.
Isn't this API breaking? You were previously importing Foundation as public but with the changed flag it is now imported as internal. Since imports are leaky in Swift this would be API breaking.
There was a problem hiding this comment.
The module still publicly imports Foundation, just in other files. So the module as a whole doesn't remove the public import.
But it's kind of moot - seems for packages that still need to support 5.x, making both 5.x and 6.x compilers warning free with explicit access modifiers on imports would require a ton of #if guards, so I'm punting on this for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Modifications
Added explicitly access modifiers on imports.
Result
Made it more explicit which types we're importing publicly and are used in our own API.
Test Plan
Tests passed, will let CI ensure this works in all our supported Swift versions.