[Runtime] Improve parameter handling of MIME types in content types #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjbeaumont
requested changes
Aug 14, 2024
…api-runtime into hd-mime-type-params
simonjbeaumont
requested changes
Nov 18, 2024
simonjbeaumont
approved these changes
Nov 19, 2024
czechboy0
added a commit
to apple/swift-openapi-generator
that referenced
this pull request
Nov 28, 2024
…#646) ### Motivation The generator piece of apple/swift-openapi-runtime#113. This is needed for APIs such as Kubernetes, that has both `application/json` and `application/json; watch=true` in a single operation. Currently the parameters weren't taken into account, which could lead to incorrect matching of content types. ### Modifications Use the full MIME type, including the parameters, for matching. ### Result More correct behavior, now we correctly handle multiple MIME types with the same type/subtype in an operation. ### Test Plan Added a unit test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In service of an upcoming generator PR - to better handle parameters in MIME types.
This is needed for APIs such as Kubernetes, that has both
application/jsonandapplication/json; watch=truein a single operation.Modifications
Use the more modern
OpenAPIMIMETypetype for parsing and comparing content types, rather than the old naive logic that ignored parameter (mis)matches.Result
More accurate handling of content types.
Test Plan
Adapted unit tests.