Confirm RuntimeErrors to HTTPResponseConvertible

apple · Dec 18, 2024 · f440264 · f440264
1 parent cd80496
commit f440264
Showing 1 changed file with 2 additions and 19 deletions.
diff --git a/Tests/OpenAPIRuntimeTests/Errors/Test_RuntimeError.swift b/Tests/OpenAPIRuntimeTests/Errors/Test_RuntimeError.swift
@@ -29,24 +29,6 @@ struct MockRuntimeErrorHandler: Sendable {
 }
 
 final class Test_RuntimeError: XCTestCase {
-    func testRuntimeError_returnsCorrectStatusCode() async throws {
-
-        let server = UniversalServer(handler: MockRuntimeErrorHandler(failWithError: RuntimeError.invalidServerURL("Invalid server URL")),
-                                     middlewares: [ErrorHandlingMiddleware()])
-        let response = try await server.handle(
-            request: .init(soar_path: "/", method: .post),
-            requestBody: MockHandler.requestBody,
-            metadata: .init(),
-            forOperation: "op",
-            using: { MockRuntimeErrorHandler.greet($0) },
-            deserializer: { request, body, metadata in
-                let body = try XCTUnwrap(body)
-                return try await String(collecting: body, upTo: 10)
-            },
-            serializer: { output, _ in fatalError() }
-        )
-        XCTAssertEqual(response.0.status, .notFound)
-    }
 
     func testRuntimeError_withUnderlyingErrorNotConfirming_returns500() async throws {
 
@@ -67,7 +49,7 @@ final class Test_RuntimeError: XCTestCase {
         XCTAssertEqual(response.0.status, .internalServerError)
     }
 
-    func testRuntimeError_withUnderlyingErrorConfirming_returns500() async throws {
+    func testRuntimeError_withUnderlyingErrorConfirming_returnsCorrectStatusCode() async throws {
 
         let server = UniversalServer(handler: MockRuntimeErrorHandler(failWithError: TestErrorConvertible.testError("Test Error")),
                                      middlewares: [ErrorHandlingMiddleware()])
@@ -90,6 +72,7 @@ final class Test_RuntimeError: XCTestCase {
 enum TestErrorConvertible: Error, HTTPResponseConvertible {
     case testError(String)
 
+    /// HTTP status code for error cases
     public var httpStatus: HTTPTypes.HTTPResponse.Status {
         .badGateway
     }