Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated examples and integration test with the new servers syntax #688

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

czechboy0
Copy link
Contributor

@czechboy0 czechboy0 commented Dec 5, 2024

Motivation

A drive-by fixup, I noticed the warnings when running the integration test locally.

Modifications

Fixed up the examples and integrate test to use the new syntax. This also meant regenerating the two examples that check in generated code, which took in a few more changes since 1.0.

Result

Syntax matches our current best practices.

Test Plan

Looks good locally.

@czechboy0 czechboy0 added the semver/none No version bump required. label Dec 5, 2024
Copy link
Collaborator

@simonjbeaumont simonjbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@simonjbeaumont simonjbeaumont enabled auto-merge (squash) December 5, 2024 10:09
@simonjbeaumont simonjbeaumont merged commit 61ec6b6 into apple:main Dec 5, 2024
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants