Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note about an open issue with code generation and SourceKit-LSP #642

Merged
merged 7 commits into from
Nov 23, 2024

Conversation

t089
Copy link
Contributor

@t089 t089 commented Oct 2, 2024

Following the discussion on Slack, this adds a note for users of SourceKit-LSP informing them that the default code generation might not work as expected and offers a possible workaround.

https://swift-open-source.slack.com/archives/C02PV8T5HQD/p1726815970093299

Only updates documentation. Let me know if you feel this is the right place for this information?

Following the discussion on Slack, this adds a note for users of SourceKit-LSP that the default code generation might not work as expected.

https://swift-open-source.slack.com/archives/C02PV8T5HQD/p1726815970093299
@simonjbeaumont
Copy link
Collaborator

Thanks for putting this up.

IMO I think we should move this to the Supported platforms and minimum versions section, since that's where we're explaining the required runtime and development environments. This is additional note on Editor Support.

Additionally, we try to keep the README and root DocC page in sync. Would you be able to update both?

Copy link
Contributor

@czechboy0 czechboy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with Si's comment, marking the PR appropriately as needs work for now

@t089 t089 requested a review from czechboy0 November 22, 2024 21:33
@t089
Copy link
Contributor Author

t089 commented Nov 22, 2024

Sorry forgot about this one, updated the PR.
CC @simonjbeaumont

@t089 t089 requested a review from czechboy0 November 23, 2024 06:51
Copy link
Contributor

@czechboy0 czechboy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@czechboy0 czechboy0 enabled auto-merge (squash) November 23, 2024 13:57
@czechboy0 czechboy0 merged commit e971af5 into apple:main Nov 23, 2024
34 checks passed
@czechboy0 czechboy0 added the semver/none No version bump required. label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants