-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Proposal] SOAR-0011: Improved error handling #626
Conversation
Please also add a link to it in the Proposals.md file 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thank you @gayathrisairam!
Added a few comments that are meant to help prepare the proposal for review (I'll hold off on commenting on the proposal itself for the review period).
Once you make these updates, we'll be able to send out the proposal for wider review.
Sources/swift-openapi-generator/Documentation.docc/Proposals/SOAR-0011.md
Outdated
Show resolved
Hide resolved
Sources/swift-openapi-generator/Documentation.docc/Proposals/SOAR-0011.md
Outdated
Show resolved
Hide resolved
Sources/swift-openapi-generator/Documentation.docc/Proposals/SOAR-0011.md
Outdated
Show resolved
Hide resolved
Sources/swift-openapi-generator/Documentation.docc/Proposals/SOAR-0011.md
Outdated
Show resolved
Hide resolved
Sources/swift-openapi-generator/Documentation.docc/Proposals/SOAR-0011.md
Show resolved
Hide resolved
…OAR-0011.md Co-authored-by: Honza Dvorsky <[email protected]>
…OAR-0011.md Co-authored-by: Honza Dvorsky <[email protected]>
…OAR-0011.md Co-authored-by: Honza Dvorsky <[email protected]>
Link to what? |
Here, a link to your proposal: swift-openapi-generator/Sources/swift-openapi-generator/Documentation.docc/Proposals/Proposals.md Line 54 in 7c36ba9
|
The proposal is now In Review, forums thread: https://forums.swift.org/t/proposal-soar-0011-improved-error-handling/74736 |
Sources/swift-openapi-generator/Documentation.docc/Proposals/SOAR-0011.md
Outdated
Show resolved
Hide resolved
…OAR-0011.md Co-authored-by: Honza Dvorsky <[email protected]>
Sources/swift-openapi-generator/Documentation.docc/Proposals/SOAR-0011.md
Outdated
Show resolved
Hide resolved
This proposal is now Ready for Implementation, see details on the forums: https://forums.swift.org/t/proposal-soar-0011-improved-error-handling/74736/31 |
…OAR-0011.md Co-authored-by: Honza Dvorsky <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Landing now, we'll update the status once we have a Runtime release with this feature included.
Motivation
Swift OpenAPI runtime doesn't allow for fine grained error handling. This PR adds a proposal for improved error handling in Swift OpenAPI runtime.
Modifications
(See the proposal for details)
Result
n/a
Test Plan
n/a