Fix multipart + additionalProperties + string support #597
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #596.
The bug was computing the
TypeUsage
from the raw schema, before resolving it with multipart semantics.Covers using the multipart content type with additional properties of a concrete type (string).
This lead to the generator producing half of the code that expected a HTTPBody (a streaming byte type) and another half expected a String, leading to a build failure.
Modifications
First resolve the schema, then calculate the
TypeUsage
from the resolved schema.Result
The generator correctly generates this as
HTTPBody
everywhere now.Test Plan
Added a unit test to cover this case.