Add the frozen keyword only to enums with the public or package modifiers
#595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 21, 2024
czechboy0
requested changes
Jul 21, 2024
|
@swift-server-bot test this please |
|
@swift-server-bot test this please |
|
For the 5.9 and 5.9.0 pipelines, we're running into the deprecation warning being escalated to an error. We already disabled warnings-as-errors on most other pipelines, please also comment out this line in the two files for 5.9 and 5.9.0, then the CI should pass. |
|
@swift-server-bot test this please |
czechboy0
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As reported in #586, using Xcode 16 Beta 3, the generated Type.swift file now shows multiple warnings due to the
@frozenattribute being applied to non-public enums.Modifications
In order to resolve the above issue, I have modified the code to annotate the
@frozenkeyword only onenumwith thepublicorpackagemodifiers.Result
No warnings are issued when the
@frozenkeyword is annotated on enums with thepublicorpackagemodifiers.