Support empty string OpenAPI identifiers #59
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The OpenAPI specification allows the use of the empty string in some places, for example in the following enum, which we've seen in some real-world OpenAPI documents:
We have code that converts an OpenAPI identifier to a suitable string that can be used as a Swift identifier. It currently returns an empty string when given an empty string as input, which is not a valid Swift identifier. We already have some logic there to avoid clashing with some Swift keywords, so this can be extended to handle the empty string.
Modifications
Result
We can generate compiling code when presented with empty string OpenAPI identifiers.
Test Plan
Resolves