Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Emphasize target setting in Xcode tutorial #58

Conversation

simonjbeaumont
Copy link
Collaborator

Motivation

In our Xcode tutorial we outline the steps to enable Swift OpenAPI Generator on a separate framework. When you come to add the package dependencies on the runtime and transport libraries the default target Xcode offers to add them to is not this new framework. Failing to add them to the framework target causes linker issues.

This is implied in our guide but it's pretty subtle and a user tripped up over this.

Modifications

  • Emphasize which target the libraries need to be added to in the Xcode tutorial.

Result

Hopefully clearer step in the tutorial.

Test Plan

Ran through the steps manually and confirmed this generates a building app.

Resolves

Resolves #57.

@simonjbeaumont simonjbeaumont requested a review from czechboy0 June 9, 2023 19:28
@simonjbeaumont
Copy link
Collaborator Author

//cc @AliakseiM

@simonjbeaumont simonjbeaumont marked this pull request as ready for review June 9, 2023 19:29
Copy link
Contributor

@czechboy0 czechboy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@simonjbeaumont simonjbeaumont added the semver/none No version bump required. label Jun 9, 2023
@simonjbeaumont simonjbeaumont merged commit 6aae3f5 into apple:main Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to reproduce "Generating a client in an Xcode project" example
2 participants