-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build IntegrationTest package as part of CI pipeline #56
Build IntegrationTest package as part of CI pipeline #56
Conversation
Signed-off-by: Si Beaumont <[email protected]>
Signed-off-by: Si Beaumont <[email protected]>
Signed-off-by: Si Beaumont <[email protected]>
97dfd65
to
70d062b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you @simonjbeaumont. Added one suggestion, otherwise you can land this. Up to you whether we land this as part of soundness now, or wait for the dedicated CI pipeline, either order is fine with me.
Signed-off-by: Si Beaumont <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @czechboy0.
Up to you whether we land this as part of soundness now, or wait for the dedicated CI pipeline, either order is fine with me.
If we land this in stages we can get the benefit now. After this PR it will be working. We can then add another pipeline and then remove it from soundness.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Motivation
We have an package in a subdirectory in this repo that we can be used as an
integration test to gate changes to the various repos in Swift OpenAPI project,
including the runtime package.
This will likely be implemented by shallow cloning this repo in the pull
request pipelines of other projects and running a script, using
swift package edit
to override the dependency on the package being tested, and building theintegration test package.
Modifications
Result
On each pull request, the integration test package will be built with the
changes proposed in the pull request.
Test Plan
The CI pipeline for this PR will run the integration test because it's been
added to the soundness script, which is run as part of an existing CI pipeline.
I have also validated this locally:
Notes
This PR adds the integration test to the soundness script, but we probably want
to split this out into its own pipeline.