Fix compiler warnings in example projects #506
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A recent example project was added that had a compiler warning which wasn't caught by CI. We can have our example code free of warnings and ensure they remain so by compiling them with
-warnings-as-errors
in CI.On further investigation, we cannot enable
-warnings-as-errors
in the examples Ci pipeline because we're reusing the shared build/cache directories which produces its own warnings for left over unused modules.Modifications
Build with-warnings-as-errors
in examples CI pipeline.Result
Example projects compile without warnings.
Test Plan
CI updated.