Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate references in validateDoc #500

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Validate references in validateDoc #500

merged 2 commits into from
Jan 8, 2024

Conversation

PARAIPAN9
Copy link
Contributor

Motivation

Modifications

  • Develop a function responsible for iterating through and validating the references within the OpenAPI document. If external references are present or if they are not found in the 'components' section, the function should throw errors.

Result

  • This will help catch invalid references before code generation.

Test Plan

  • Make sure that tests pass and wrote additional unit tests.

@simonjbeaumont
Copy link
Collaborator

@swift-server-bot test this please

@simonjbeaumont
Copy link
Collaborator

Thanks @PARAIPAN9!

@PARAIPAN9
Copy link
Contributor Author

You're welcome, always a pleasure to contribute!!

@czechboy0 czechboy0 merged commit f58f60d into apple:main Jan 8, 2024
9 checks passed
@czechboy0 czechboy0 added the 🔨 semver/patch No public API change. label Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czechboy0 czechboy0 czechboy0 approved these changes

@simonjbeaumont simonjbeaumont simonjbeaumont approved these changes

Assignees
No one assigned
Labels
🔨 semver/patch No public API change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate references in validateDoc
3 participants
@PARAIPAN9 @simonjbeaumont @czechboy0