Validate content type strings in validateDoc

[PARAIPAN9]

Motivation

• Fixes Validate content-type strings in validateDoc #342.

Modifications

• Create extracting and validation functions for content type strings.

Result

• This will help catch invalid content types before code generation.

Test Plan

• Test it on an openapi document to make sure the errors are thrown as intended and wrote additional unit tests.

[simonjbeaumont]

Thanks for your continued efforts @PARAIPAN9 ❤️. We'll take a look at this, but just to manage your expectations, we'll likely want to merge this after we ship 1.0.0 (hopefully on Wednesday). This could well be the first post-1.0 PR though :)

[simonjbeaumont]

@swift-server-bot test this please

[PARAIPAN9]

You're very welcome! Thank you for considering the changes, and I completely understand the priority of shipping 1.0.0 first. I'm thrilled to contribute, and eagerly looking forward to the exciting milestone of the first release.

[czechboy0]

Hi @PARAIPAN9 - the issue might not have been super clear, but the issue was about doing the work of walking the OpenAPI document, and validating all the content type strings that exist there, in the validateDoc function.

That way, we'd catch invalid content types at the start, instead of doing so later when we're trying to generate code.

The errors emitted today, when an invalid content type is encountered, are good enough, we just don't do the validation at the start, so it can lead to a more confusing debugging experience.

Does that make sense? If that task is not something you want to pick up, no worries at all, just let me know and I'd unassign you. 🙂

[czechboy0]

See comment above, the task is slightly different.

[PARAIPAN9]

Ah, thank you for the clarification. It's ok, I'll continue working on it.

[czechboy0]

Thanks - just a few more comments about how we can validate all the content types and emit more information if an invalid content type is found.

[czechboy0]

Great, we're basically there - just added a few more suggestions, but this is the right shape!

[czechboy0]

Great, thank you! Let's just get the CI green and I'll merge it.

[czechboy0]

@swift-server-bot test this please

[PARAIPAN9]

Perfect, You’re welcome!!