Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default the access modifier to internal #441

Merged
merged 3 commits into from
Dec 8, 2023
Merged

Default the access modifier to internal #441

merged 3 commits into from
Dec 8, 2023

Conversation

czechboy0
Copy link
Contributor

Motivation

After further consideration, internal seems the be the right default for access modifier of the generated, mirroring Swift itself.

Modifications

Switch the default to internal and update docs.

Result

accessModifier: internal is the default now.

Test Plan

Updated tests.

simonjbeaumont
simonjbeaumont requested changes Dec 8, 2023
View reviewed changes
Copy link
Collaborator

@simonjbeaumont simonjbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration test relied on public or package. Probably needs making package explicitly.

simonjbeaumont
simonjbeaumont approved these changes Dec 8, 2023
View reviewed changes
Copy link
Collaborator

@simonjbeaumont simonjbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@czechboy0 czechboy0 enabled auto-merge (squash) December 8, 2023 13:36
@czechboy0 czechboy0 merged commit 4a3c485 into apple:main Dec 8, 2023
9 checks passed
@czechboy0 czechboy0 deleted the hd-access-modifier-default-internal branch December 8, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjbeaumont simonjbeaumont simonjbeaumont approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@czechboy0 @simonjbeaumont