Update minimum version of OpenAPIKit to 3.1.2 #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was only a bug for 3.0.3, not 3.1.0. We only run snippet tests for 3.1.0. While I'm happy with the change, I don't think we should be testing 3.0.3 behavior in our project beyond the fact that we can load and convert it. So I'd prefer not to add that test, and just test it manually one time. Otherwise it feels like testing our dependencies. |
|
Oh it seems 3.1.2 also changed some diagnostics emitted by OpenAPIKit, so we'll need to update the compat suite. I suspect a few expected diagnostics will be able to be removed. |
czechboy0
approved these changes
Dec 8, 2023
|
Landing this to unblock other PRs. Compat suite passed, which is the only thing changed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This picks up a bug fix with inferred properties. While Swift package resolution should pick this up for adopters automatically, we want to go into 1.0 with the minimum version of the dependency bumped to one that includes the fix.
Modifications
Update minimum version of OpenAPIKit to 3.1.2
Result
Requires newer OpenAPIKit with fix.
Test Plan
CI.