Remove unneeded target dependencies from HelloWorldVaporServerTests #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was struggling to get this working without the extra dependencies, was getting a linker issue. Let's debug this together. |
Sure. Odd: I see the CI failed too. But locally, this builds fine, from clean. |
|
Superseded by #487. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The HelloWorld example had a test target that had the same target dependencies as the source target. These weren't necessary and, if these are going to be examples, they should be cleaned up to be as minimal as possible.
Modifications
Remove unneeded dependencies from HelloWorldVaporServerTests target.
Result
Simpler Package.swift
(And, annoyingly formatted Package.swift, due to swift-format)
Test Plan
CI should still be fine.