Add visionOS to Package.swift to emit useful compilation errors #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czechboy0
approved these changes
Nov 27, 2023
czechboy0
reviewed
Nov 27, 2023
czechboy0
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We have provision for emitting a useful compilation error when trying to link the generator to an application on darwin platforms, e.g. iOS, tvOS, watchOS. To support this, we add those platforms to the Package.swift so that the code at least tries to compile and then we can emit the
#error. This list does not currently include visionOS so users will not get the same useful compilation error.Modifications
Add visionOS to the platforms in Package.swift. While there, also add this to the platforms in the Package.swift for the client used in the tutorial.
Result
When compiling for visionOS and trying to link the generator, a useful compiler error will be emitted.
Test Plan
Manual.