Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation of tests on older macOS #385

Merged

Conversation

simonjbeaumont
Copy link
Collaborator

Motivation

The tests fail to compile on anything older than macOS 13, because they use Collection.split(separator:maxSplits:omittingEmptySubsequences:), which is only available in macOS 13+.

Modifications

Rather than use -> in the stringified tests, use just >, which means the function resolves to String.split(separator:maxSplits:omittingEmptySubsequences:), which is available on older platforms.

Result

Tests can be built on older platforms.

Test Plan

Manual verification.

@czechboy0
Copy link
Contributor

Whoops, thanks

@simonjbeaumont simonjbeaumont force-pushed the sb/fix-compilation-on-macOS-12 branch from be8d0e2 to b143565 Compare November 17, 2023 17:14
@simonjbeaumont simonjbeaumont marked this pull request as ready for review November 17, 2023 17:29
@simonjbeaumont simonjbeaumont merged commit 7f6baf7 into apple:main Nov 17, 2023
8 checks passed
@czechboy0 czechboy0 added the 🔨 semver/patch No public API change. label Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants