Bump to OpenAPIKit 3.0.0 #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
OpenAPIKit released 3.0.0, so let's move to it.
Modifications
They (correctly) removed the
format: byteandformat: binaryfields in the OpenAPI 3.1 mode, insteadcontentEncoding: base64andcontentEncoding: binaryshould be used.For docs that load as 3.0 and get converted to 3.1 in memory, this translation happens automatically in OpenAPIKit, so we just need to be able to handle 3.1 documents here.
Result
Using the stable v3 version of OpenAPIKit, which will allow Swift OpenAPI Generator to coexist with other projects that depend on OpenAPIKit v3 (previously, locking to an exact version of OpenAPIKit meant more difficult version resolution for adopters.)
Test Plan
Adapted tests, all pass now.