Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inline response headers #355

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

czechboy0
Copy link
Contributor

Motivation

When generating a response header that points to an inline schema, the generator didn't generate the definition of the inline schema, so the code wouldn't compile.

Modifications

Make changes to properly compute optionality (drive-by improvement) and generate the inline type, if needed.

Result

Inline response header schemas now compile.

Test Plan

Added a snippet test for this.

@czechboy0 czechboy0 merged commit cf15973 into apple:main Oct 31, 2023
@czechboy0 czechboy0 deleted the hd-inline-response-headers branch October 31, 2023 12:15
@czechboy0 czechboy0 added the 🔨 semver/patch No public API change. label Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants