Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a soundness --fix flag #345

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Conversation

czechboy0
Copy link
Contributor

Motivation

When running ./scripts/soundness.sh produces swift-format warnings, we ask adopters to manually copy/paste a call to swift format to fix the warnings up. This is tedious and unnecessary.

Modifications

Add a --fix option on the soundness.sh script to actually apply the fixes as well, avoiding the need to copy/paste long commands.

Result

Easier fixing up of formatting warnings.

Test Plan

Manually tested the workflow locally.

scripts/soundness.sh Outdated Show resolved Hide resolved
Co-authored-by: George Barnett <[email protected]>
@czechboy0 czechboy0 merged commit f071608 into apple:main Oct 25, 2023
@czechboy0 czechboy0 deleted the hd-soundness-fix branch October 25, 2023 10:31
@czechboy0 czechboy0 added the semver/none No version bump required. label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants