Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker-compose file for 5.10 CI #317

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

simonjbeaumont
Copy link
Collaborator

@simonjbeaumont simonjbeaumont commented Oct 3, 2023

Motivation

Now Swift 5.9 is released and 5.10 nightly images are available, we should update our CI to use the official release for 5.10 and setup a new CI for 5.10.

Modifications

  • Update 5.9 CI to use swift:5.9-jammy
  • Add new CI for swiftlang/swift:nightly-5.10-jammy

Result

  • 5.9 CI is using official released image.
  • 5.10 CI can be brought online.

Test Plan

Running both of these commands locally succeed:

% docker-compose -f docker/docker-compose.yaml -f docker/docker-compose.2204.59.yaml run test
% docker-compose -f docker/docker-compose.yaml -f docker/docker-compose.2204.510.yaml run test

Copy link
Contributor

@czechboy0 czechboy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion

@simonjbeaumont
Copy link
Collaborator Author

@yim-lee could we trouble you to enable a new pipeline for 5.10. The following command runs fine locally, and we can use this PR as a test.

docker-compose -f docker/docker-compose.yaml -f docker/docker-compose.2204.510.yaml run test

@yim-lee
Copy link
Member

yim-lee commented Oct 3, 2023

@swift-server-bot test this please

@simonjbeaumont simonjbeaumont marked this pull request as ready for review October 4, 2023 07:08
@simonjbeaumont simonjbeaumont merged commit 8954706 into apple:main Oct 4, 2023
@czechboy0 czechboy0 added the semver/none No version bump required. label Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants