Skip building generated Github APIs in compat test #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-server-bot compat-test-full |
|
Hm... There are two compilations that got SIGKILLED... 🤔 https://ci.swiftserver.group/job/swift-openapi-generator-compatibility-test-full-prb/6/console |
|
@swift-server-bot compat-test-full |
czechboy0
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We have an opt-in CI pipeline configured that is triggered by a comment. It runs the same compatibility test that's run in the automatic pipeline, which generates code for a set of real-world OpenAPI documents, but, additionally, it builds the generated code.
However, the Github APIs are so large that we cannot compile them in a reasonable amount of time in CI, if we want to compile the others.
Modifications
Skip building the generated code for Github APIs, even on the opt-in pipeline.
Result
The opt-in pipeline now runs in ~22 minutes.
Test Plan
We'll use this PR to trigger the CI to confirm it completes, and in a reasonable time.