Move warning about strict concurrency into PlatformChecks.swift #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In #191 we enabled strict concurrency in CI. We also attempted to include it conditionally as part of a local development flow. However, the
#warning(that strict concurrency was enabled) added to Package.swift was firing unconditionally because it was, itself, behind a runtime conditional.Modifications
Now if
SWIFT_OPENAPI_STRICT_CONCURRENCY=truethen we will add adefineto theswiftSettingsand we will move the#warningto the existingPlatformChecks.swift.Result
Opening Xcode with
SWIFT_OPENAPI_STRICT_CONCURRENCY=truewill enable strict concurrency warnings locally. Opening Xcode without this will no longer produce a misleading warning.Test Plan
Tested locally.