Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #78 - Explicitly name reusable header types as 'response header' types #284

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Fixes #78 - Explicitly name reusable header types as 'response header' types #284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Sources/_OpenAPIGeneratorCore/Translator/Responses/TypedResponseHeader.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,19 +86,19 @@ extension FileTranslator {

/// Returns a typed response header for the provided unresolved header.
/// - Parameters:
/// - unresolvedHeader: The header specified in the OpenAPI document.
/// - unresolvedResponseHeader: The header specified in the OpenAPI document.
/// - name: The name of the header.
/// - parent: The Swift type name of the parent type of the headers.
/// - Returns: Typed response header if supported, nil otherwise.
func typedResponseHeader(
from unresolvedHeader: UnresolvedHeader,
from unresolvedResponseHeader: UnresolvedResponseHeader,
named name: String,
inParent parent: TypeName
) throws -> TypedResponseHeader? {

// Collect the header
let header: OpenAPI.Header
switch unresolvedHeader {
switch unresolvedResponseHeader {
case let .a(ref):
header = try components.lookup(ref)
case let .b(_header):
Expand Down Expand Up @@ -143,7 +143,7 @@ extension FileTranslator {
}

let type: TypeUsage
switch unresolvedHeader {
switch unresolvedResponseHeader {
case let .a(ref):
type = try typeAssigner.typeName(for: ref).asUsage
case .b:
Expand Down Expand Up @@ -173,4 +173,4 @@ extension FileTranslator {
/// An unresolved OpenAPI response header.
///
/// Can be either a reference or an inline response header.
typealias UnresolvedHeader = Either<OpenAPI.Reference<OpenAPI.Header>, OpenAPI.Header>
typealias UnresolvedResponseHeader = Either<OpenAPI.Reference<OpenAPI.Header>, OpenAPI.Header>