Run integration test in $TMPDIR or /tmp #279
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Our CI workspace is filling up with integration test runs. This is because they are created in a temporary directory within the current working directory.
Modifications
In the integration test script, do everything under
$TMPDIR
or/tmp
, if$TMPDIR
is unset.Note that this script needs to run on macOS and Linux so we have used a set of arguments to
mktemp
which results in similar behaviour on both platforms:Note also that, on macOS, the
XXXXXX
needs to be at the end, so we've had to stop adding.noindex
to the end of the directory name.Result
No longer clogging up CI workspace with integration test builds.
Test Plan
Tested locally and in
docker-compose
: