Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include parameters in the content type name #236

Merged

Conversation

czechboy0
Copy link
Contributor

Motivation

Fixes #232, which was blocking the Kubernetes OpenAPI doc from successfully generating and building.

Modifications

Include parameters, such as application/json; foo=bar in the content type name, e.g. application_json_foo_bar.

Result

#232 is fixed, verified already locally.

Test Plan

Updated unit and snippet tests.

@czechboy0 czechboy0 merged commit e02d4b8 into apple:main Aug 31, 2023
@czechboy0 czechboy0 deleted the hd-include-parameters-in-content-type-name branch August 31, 2023 10:48
@czechboy0 czechboy0 added the 🆕 semver/minor Adds new public API. label Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🆕 semver/minor Adds new public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include any parameters in content type unique names
3 participants