Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All descriptions defined in the OpenAPI document are generated #213

Merged
merged 1 commit into from
Aug 20, 2023
Merged

All descriptions defined in the OpenAPI document are generated #213

merged 1 commit into from
Aug 20, 2023

Conversation

takeshi-1000
Copy link
Contributor

Motivation

Resolve #206

Modifications

Passed description defined in OpenAPI document to some docCommentWithUserDescription

Result

Parameter descriptions such as query, request header, response header are now generated in Types.swift

Test Plan

  • Modified Types.swift in Petstore so that test passed
  • Added description for openapi.yaml in test code to ensure this fix

czechboy0
czechboy0 approved these changes Aug 20, 2023
View reviewed changes
Copy link
Contributor

@czechboy0 czechboy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @takeshi-1000!

@czechboy0 czechboy0 merged commit 3ffeaba into apple:main Aug 20, 2023
@takeshi-1000 takeshi-1000 deleted the generated-description branch August 20, 2023 10:56
@czechboy0 czechboy0 added the 🔨 semver/patch No public API change. label Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czechboy0 czechboy0 czechboy0 approved these changes

Assignees
No one assigned
Labels
🔨 semver/patch No public API change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not all descriptions defined in the OpenAPI document are generated
2 participants
@takeshi-1000 @czechboy0