Fix warning in generated server code #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @czechboy0! I'm not sure where to add a proper test for this, do you have any idea how I could write a good test for this scenario? 🙂 |
|
Sure - using a snippet test would be ideal. But I'll have to create a new util function for it, let me push it directly into your branch, will let you know when it's ready. |
|
@arthurcro here you go: 2faf804 I created a test called |
|
That's aweomse @czechboy0, thank you so much! I'll add the missing test as soon as possible and mark the PR as ready! 🙂 |
arthurcro
force-pushed
the
fix-generated-server-warning
branch
from
d95b7ee to
49b3115
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #190.
Modifications
We fix the issue buy only generating this initializer if there's at least one operation. Otherwise keep the method empty.
Result
The warning is fixed since the
servervariable declaration is not added to theregisterHandlersbody when it's not used.Test Plan
We add a test in
SnippetBasedReferenceTests.swiftcalledtestServerRegisterHandlers_noOperationsasserting theservervariable delcaration is not added to theregisterHandlersbody.