-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ContentType + improve content type matching #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
reviewed
Aug 7, 2023
Sources/_OpenAPIGeneratorCore/Translator/Content/ContentType.swift
Outdated
Show resolved
Hide resolved
Sources/_OpenAPIGeneratorCore/Translator/Content/ContentType.swift
Outdated
Show resolved
Hide resolved
gjcairo
approved these changes
Aug 7, 2023
glbrntt
approved these changes
Aug 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but could you add a comment to the binary
case before merging?
glbrntt
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
ContentType
type had two issues:foo/bar+json
as a JSON content typeModifications
Refactored
ContentType
to split the raw value storage from theCategory
(new term, ideas of a better name are welcome) of content types (json
,text
, orbinary
).Also, improved the mapping to match https://json-schema.org/draft/2020-12/json-schema-core.html#section-4.2
Result
Now the type is easier to work with, and parsing correctly recognizes
foo/bar+json
as JSON.Test Plan
Added unit tests.