Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Handle the '\r\n' newline correctly #169

Merged
merged 4 commits into from
Aug 4, 2023

Conversation

czechboy0
Copy link
Contributor

@czechboy0 czechboy0 commented Aug 3, 2023

Motivation

Fixes #143, which tracks including the '\r\n' newline in a description in the OpenAPI document.

Modifications

Replaces the '\r\n' character with '\n' before rendering comments, as '\n' is handled properly.

Result

OpenAPI documents that include '\r\n' in a description produce compiling code now.

Test Plan

Added a unit test for this case.

@czechboy0
Copy link
Contributor Author

@swift-server-bot test this please

@czechboy0 czechboy0 changed the title [Bug] Handle the '\r' character correctly [Bug] Handle the '\r\n' newline correctly Aug 4, 2023
@czechboy0 czechboy0 merged commit 01c12f5 into apple:main Aug 4, 2023
@czechboy0 czechboy0 deleted the hd-handler-return-character branch August 4, 2023 07:24
@czechboy0 czechboy0 added the 🔨 semver/patch No public API change. label Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Including the '\r\n' newline in a description results in non-compiling code
2 participants