Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a proposal state for when merged behind a feature flag #161

Merged
merged 3 commits into from
Aug 2, 2023

Conversation

czechboy0
Copy link
Contributor

Motivation

When introducing breaking changes, it can be convenient to hide the new behavior behind a feature flag. However, up until now, proposals didn't have a state that represents "feature landed but is not enabled by default yet".

Modifications

This PR introduces a new state for proposals for this.

Also, added missing documentation for the featureFlags key in the config file.

Result

Now proposals can be moved to the new state before their feature is enabled unconditionally.

Test Plan

N/A

@czechboy0 czechboy0 merged commit ea1a1db into apple:main Aug 2, 2023
@czechboy0 czechboy0 deleted the hd-add-feature-flag-proposal-state branch August 2, 2023 08:38
@czechboy0 czechboy0 added the semver/none No version bump required. label Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants