Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable .swift-format option UseSynthesizedInitializer once swift-format 5.9 is released #250

Closed
czechboy0 opened this issue Sep 7, 2023 · 0 comments · Fixed by apple/swift-openapi-runtime#68
Closed

Re-enable .swift-format option UseSynthesizedInitializer once swift-format 5.9 is released #250

czechboy0 opened this issue Sep 7, 2023 · 0 comments · Fixed by apple/swift-openapi-runtime#68
Labels
area/generator Affects: plugin, CLI, config file. kind/administration CI, repo automation, other admin tasks. size/S Small task. (A couple of hours of work.) status/blocked Waiting for another issue.
Milestone
1.0

Comments

@czechboy0
Copy link
Contributor

Blocked on swiftlang/swift-format#592 being in a release, most likely will be in the upcoming 5.9.
@czechboy0 czechboy0 added area/generator Affects: plugin, CLI, config file. kind/administration CI, repo automation, other admin tasks. size/S Small task. (A couple of hours of work.) status/blocked Waiting for another issue. labels Sep 7, 2023
@czechboy0 czechboy0 modified the milestones: 1.0, Post-1.0 Sep 7, 2023
@czechboy0 czechboy0 mentioned this issue Sep 7, 2023
Merged
1 task
@missingmario missingmario mentioned this issue Sep 25, 2023
Closed
@czechboy0 czechboy0 modified the milestones: Post-1.0, 1.0 Oct 27, 2023
@czechboy0 czechboy0 mentioned this issue Oct 31, 2023
Merged
czechboy0 added a commit to apple/swift-openapi-runtime that referenced this issue Oct 31, 2023
@czechboy0
Apply the same .swift-format as the generator repo (#68)
f6085a3 
Apply the same .swift-format as the generator repo

### Motivation

Bring the runtime library formatting in line with the generator repo.

Also fixes apple/swift-openapi-generator#250.

### Modifications

Copied the `.swift-format` file, reran swift-format.

Only formatting changes.

### Result

Consistent style.

### Test Plan

CI.


Reviewed by: gjcairo

Builds:
     ✔︎ pull request validation (5.10) - Build finished. 
     ✔︎ pull request validation (5.8) - Build finished. 
     ✔︎ pull request validation (5.9) - Build finished. 
     ✔︎ pull request validation (api breakage) - Build finished. 
     ✔︎ pull request validation (docc test) - Build finished. 
     ✔︎ pull request validation (integration test) - Build finished. 
     ✔︎ pull request validation (nightly) - Build finished. 
     ✔︎ pull request validation (soundness) - Build finished. 

#68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/generator Affects: plugin, CLI, config file. kind/administration CI, repo automation, other admin tasks. size/S Small task. (A couple of hours of work.) status/blocked Waiting for another issue.
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Apply the same .swift-format as the generator repo czechboy0/swift-openapi-runtime
1 participant
@czechboy0