Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigInt Fixes for Issues in Violet Tests #262

Open
wants to merge 7 commits into
base: biginteger
Choose a base branch
from
Open

BigInt Fixes for Issues in Violet Tests #262

wants to merge 7 commits into from

Commits on Apr 18, 2023

  1. Added improved LosslessStringConvertible init() with order of magnitu… 

    …de faster performance.

Removed unnecessary _digits and _digitRadix.
Fixed a cut/paste problem in "^=" function.
Added test cases for string conversion performance and logical operation tests.
    @mgriebling
    mgriebling committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    d73aef0 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2023

  1. Fixed a negate() corner case issue where a negative integer was turne… 

    …d into a negative.

Fixed division/remainder signs after a multi-word division.
    @mgriebling
    mgriebling committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    4009679 View commit details
    Browse the repository at this point in the history

  2. Fixes issue with FloatingPoint overflow and other integer test overfl… 

    …ows.
    @mgriebling
    mgriebling committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    5e55107 View commit details
    Browse the repository at this point in the history

  3. Fix corner-case overflow with Int.min and -1 division.

    @mgriebling
    mgriebling committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    67b17c2 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2023

  1. Added new CustomStringConvertible implementation (20X to 70X faster t… 

    …han the default).
    @mgriebling
    mgriebling committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    01928d0 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2023

  1. New implementation for LosslessStringConvertible init?(); speeds conv… 

    …ersions by 35X to 310X times over original code.

New implementation for CustomStringConvertible toString(); speeds conversions by 20X to 90X times over original code.
    @mgriebling
    mgriebling committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    696ea95 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2023

  1. Removed Foundation import from BigInt. 

    Added an additional check to isValidPowerOfTwoRadix so odd numbers of bits (except radix 2) don't use the fast path in toString.
Now use a table lookup to determine the radix number bits.
Added a check for iOS for StringLiteralType.  Tested code under iOS and macOS under simulator and x86
    @mgriebling
    mgriebling committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    1fc9e13 View commit details
    Browse the repository at this point in the history