add forgotten selfs #574
Merged
add forgotten selfs #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Swift code that doesn't use explicit `self.` is hard to read, even harder to search for and quite bug prone. During my analysis I found quite a number of them, this fixes the ones I came across. Modifications: Add a bunch of missing explicit `self.`s Result: code easier to read and less bug prone
Lukasa
approved these changes
Aug 16, 2018
weissi
added a commit
that referenced
this pull request
Aug 29, 2018
Motivation: Swift code that doesn't use explicit `self.` is hard to read, even harder to search for and quite bug prone. During my analysis I found quite a number of them, this fixes the ones I came across. Modifications: Add a bunch of missing explicit `self.`s Result: code easier to read and less bug prone Motivation: Explain here the context, and why you're making that change. What is the problem you're trying to solve. Modifications: Describe the modifications you've done. Result: After your change, what will change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Swift code that doesn't use explicit
self.is hard to read, evenharder to search for and quite bug prone. During my analysis I found
quite a number of them, this fixes the ones I came across.
Modifications:
Add a bunch of missing explicit
self.sResult:
code easier to read and less bug prone