tests hygiene: a lot fewer naked trys
#552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weissi
force-pushed
the
jw-better-debugging
branch
from
65fe495 to
e3d543d
Compare
Motivation: Naked `try`s in tests are a problem because if they're hit you'll get a bad error message and likely no file/line information. That has made many flaky tests harder to debug than necessary. Modifications: - fix a lot of naked `try`s - symlink `TestUtils` from `NIOTests` into `NIOHTTP1Tests` - make a bunch of `wait()`s synchronous that were asynchronous by accident Result: - better code - easier to debug test failures - setting better example
weissi
force-pushed
the
jw-better-debugging
branch
from
e3d543d to
854eea7
Compare
Lukasa
requested changes
Aug 6, 2018
| @@ -0,0 +1 @@ | |||
| ../NIOTests/TestUtils.swift | |||
There was a problem hiding this comment.
Rather than create this symlink, should we just move this into a target and depend on it from the two test targets?
There was a problem hiding this comment.
@Lukasa SwiftPM doesn't unfortunately support that AFAIK. We can't make it a test target as we can't depend on that and we can't make it a normal target as it depends on XCTest. Therefore this is the only way I'm aware of...
Lukasa
approved these changes
Aug 6, 2018
weissi
added a commit
that referenced
this pull request
Aug 29, 2018
Motivation: Naked `try`s in tests are a problem because if they're hit you'll get a bad error message and likely no file/line information. That has made many flaky tests harder to debug than necessary. Modifications: - fix a lot of naked `try`s - symlink `TestUtils` from `NIOTests` into `NIOHTTP1Tests` - make a bunch of `wait()`s synchronous that were asynchronous by accident Result: - better code - easier to debug test failures - setting better example Motivation: Explain here the context, and why you're making that change. What is the problem you're trying to solve. Modifications: Describe the modifications you've done. Result: After your change, what will change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Naked
trys in tests are a problem because if they're hit you'll get abad error message and likely no file/line information. That has made
many flaky tests harder to debug than necessary.
Modifications:
trysTestUtilsfromNIOTestsintoNIOHTTP1Testswait()s synchronous that were asynchronous byaccident
Result: