Make bad websocket parser states unrepresentable. #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Apparently when I wrote the WebSocket parser I forgot that enums are great, and so I added a bunch of optional properties. That was silly. This patch changes the WSParser structure to use an enum with associated data to ensure that we only store state when we are supposed to, and to guarantee that the state is good. Modifications: Move all state to enum case associated data. Result: Easier to validate the correctness of the WSParser code.
weissi
pushed a commit
that referenced
this pull request
Aug 29, 2018
Motivation: Apparently when I wrote the WebSocket parser I forgot that enums are great, and so I added a bunch of optional properties. That was silly. This patch changes the WSParser structure to use an enum with associated data to ensure that we only store state when we are supposed to, and to guarantee that the state is good. Modifications: Move all state to enum case associated data. Result: Easier to validate the correctness of the WSParser code. Motivation: Explain here the context, and why you're making that change. What is the problem you're trying to solve. Modifications: Describe the modifications you've done. Result: After your change, what will change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Apparently when I wrote the WebSocket parser I forgot that enums are
great, and so I added a bunch of optional properties. That was silly.
This patch changes the WSParser structure to use an enum with
associated data to ensure that we only store state when we are supposed
to, and to guarantee that the state is good.
Modifications:
Move all state to enum case associated data.
Result:
Easier to validate the correctness of the WSParser code.